[Webkit-unassigned] [Bug 25756] Explicit guards for ENABLE_GEOLOCATION

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25756





--- Comment #15 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-03-29 21:09:19 PST ---
(In reply to comment #14)
> Created an attachment (id=51953)
 --> (https://bugs.webkit.org/attachment.cgi?id=51953) [details]
> fix ChangeLog
> 
> Thanks for the review, David. I fixed the ChangeLog.
> 
> I considered your suggestion of moving stub implementation is in the header
> file; however I think that would mean that those symbols could not not get
> exported. I was trying to minimize the impact on clients, so that a stub symbol
> is still exported for most symbols. For example Geolocation::setIsAllowed() is
> still listed in WebCore.base.exp.
> 
> Moving those symbols to the header would mean moving some more symbols over to
> WebCore.Geolocation.exp and making more changes under WebKit/mac. I'm happy to
> make those changes if that is the direction we want to take this patch.
> 
> For now, I just resubmitted the patch with only changes in the ChangeLog.

So there are two options here--move the exported symbols to
WebCore.Geolocation.exp and add more ENABLE(GEOLOCATION) macros to WebKit, or
leave it as is.  If you want to save more space, I would move more symbols to
the export file, but I'll review the current patch as-is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.