[Webkit-unassigned] [Bug 25756] Explicit guards for ENABLE_GEOLOCATION

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 12:58:41 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=25756


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51798|0                           |1
        is obsolete|                            |
  Attachment #51953|                            |review?
               Flag|                            |




--- Comment #14 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-03-29 12:58:40 PST ---
Created an attachment (id=51953)
 --> (https://bugs.webkit.org/attachment.cgi?id=51953)
fix ChangeLog

Thanks for the review, David. I fixed the ChangeLog.

I considered your suggestion of moving stub implementation is in the header
file; however I think that would mean that those symbols could not not get
exported. I was trying to minimize the impact on clients, so that a stub symbol
is still exported for most symbols. For example Geolocation::setIsAllowed() is
still listed in WebCore.base.exp.

Moving those symbols to the header would mean moving some more symbols over to
WebCore.Geolocation.exp and making more changes under WebKit/mac. I'm happy to
make those changes if that is the direction we want to take this patch.

For now, I just resubmitted the patch with only changes in the ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list