[Webkit-unassigned] [Bug 36395] [Qt] Patch to add support for Content-Disposition...

Mon Mar 29 18:20:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=36395

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |beidson at apple.com

--- Comment #39 from Brady Eidson <beidson at apple.com>  2010-03-29 18:20:14 PST ---
I emailed webkit-dev the following:

Since two platforms now share this same code in their WebKit layers, it seems
okay that this was moved into some shared location.  But I have a few gripes:

HTTPParsers is about parsing HTTP, not implementing policy.  A better place is
probably ResourceResponse itself.

But as written the method implements a client policy.  This reeks of breaking
the layering between WebCore and WebKit.  I would feel a lot better about it if
the method was:
String ResourceResponseBase::contentDispositionType() const;

...and then the clients made their own decision based on that.  Safari actually
does this, for example.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.