[Webkit-unassigned] [Bug 36481] Web Inspector: Edit Tag Names

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36481





--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org>  2010-03-28 01:54:22 PST ---
Committed r56683
    M    WebCore/ChangeLog
    M    WebCore/inspector/InspectorFrontend.cpp
    M    WebCore/inspector/InspectorBackend.h
    M    WebCore/inspector/InspectorDOMAgent.h
    M    WebCore/inspector/InspectorBackend.idl
    M    WebCore/inspector/front-end/ElementsTreeOutline.js
    M    WebCore/inspector/front-end/DOMAgent.js
    M    WebCore/inspector/front-end/treeoutline.js
    M    WebCore/inspector/InspectorFrontend.h
    M    WebCore/inspector/InspectorBackend.cpp
    M    WebCore/inspector/InspectorDOMAgent.cpp
r56683 = bb9632f89ccbbeb6ff2a4c8913567bbe2337180f (trunk)
http://trac.webkit.org/changeset/56683

Committed r56684
    M    WebCore/ChangeLog
    M    WebCore/inspector/front-end/ElementsTreeOutline.js
    M    WebCore/inspector/front-end/inspector.css
http://trac.webkit.org/changeset/56684


(In reply to comment #17)
> (From update of attachment 51850 [details])
> > +void InspectorDOMAgent::changeTagName(long callId, long nodeId, const AtomicString& tagName, bool expanded)
> Assert non-element case early as well?
> 

Done. I thought about this before and I agree. I also removed usage of
"newNode" and just used "newElem" throughout, since Element is the result from
document()->createElement(...).

> If you ignore previous call code, you should at least clear it before the
> subsequent one I guess.

ContainerNode::appendChild clears out the exception code each time. And, I
don't check it for these operations, since even if I'm half way through, I want
to keep going.

> > +        try {
> > +            document.createElement(newText);
> > +        } catch(e) {
> > +            cancel.call(this);
> > +            return;
> > +        }
> 
> I am not sure this is necessary. You should rely on error codes on backend
> side.

I removed this in favor of checking the exception code from the backend's
createElement call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.