[Webkit-unassigned] [Bug 36481] Web Inspector: Edit Tag Names

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36481


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51852|review?                     |review+
               Flag|                            |




--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2010-03-28 00:56:48 PST ---
(From update of attachment 51852)
> +            var previous = element.previousSibling;
> +            if (!previous || previous.nodeType !== Node.TEXT_NODE)
> +                element.parentNode.insertBefore(document.createTextNode(" "), element);
> +            element.outerHTML = "<span class=\"webkit-html-attribute\">" +
> +                                  "<span class=\"webkit-html-attribute-name\">" + attr.name.escapeHTML() + "</span>=​\"" +
> +                                  "<span class=\"webkit-html-attribute-value\">" + attr.value.escapeHTML() + "</span>​\"" +
> +                                "</span>";

I really don't like these snippets spread all over the code in various methods.
We really should do it in single place!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.