[Webkit-unassigned] [Bug 36625] Modify NotificationPresenter::checkPermission() to pass the full source url rather than just the security origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36625





--- Comment #9 from Aaron Boodman <aa at chromium.org>  2010-03-27 10:11:29 PST ---
(In reply to comment #7)
> (In reply to comment #4)
> > This is to work around a GKURL KURL difference, correct?
> 
> If this is true, then can we eliminate the difference?

It isn't true. Eric was getting this patch confused with something else I was
talking to him about the same day.

There is a difference between GURL and KURL though. See:

https://bugs.webkit.org/show_bug.cgi?id=36623(In reply to comment #8)
> (From update of attachment 51693 [details])
> > +++ b/WebKit/chromium/public/WebNotificationPresenter.h
> > @@ -62,7 +62,7 @@ public:
> >  
> >      // Checks the permission level for the given origin.
> >      // FIXME: This should become abstract when the below is removed.
> > -    virtual Permission checkPermission(const WebSecurityOrigin& origin)
> > +    virtual Permission checkPermission(const WebURL& url)
> 
> Doesn't this make for a two-sided commit?  Can we avoid such complexity
> by preserving the old API in a deprecated form and then remove it via
> a follow-up patch?

No. Note the WebSecurityOrigin signature is not used in Chromium and has a
default implementation. It was a previous (aborted) attempt at this same
change, and is intended to be made in three non-breaking steps.

BTW, We need a name for the desired way to make webkit changes. Air-lock?
Three-phase?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.