[Webkit-unassigned] [Bug 36625] Modify NotificationPresenter::checkPermission() to pass the full source url rather than just the security origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36625





--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-26 19:57:30 PST ---
(From update of attachment 51693)
> +++ b/WebKit/chromium/public/WebNotificationPresenter.h
> @@ -62,7 +62,7 @@ public:
>  
>      // Checks the permission level for the given origin.
>      // FIXME: This should become abstract when the below is removed.
> -    virtual Permission checkPermission(const WebSecurityOrigin& origin)
> +    virtual Permission checkPermission(const WebURL& url)

Doesn't this make for a two-sided commit?  Can we avoid such complexity
by preserving the old API in a deprecated form and then remove it via
a follow-up patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.