[Webkit-unassigned] [Bug 36520] [DRT/Chromium] Add LayoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 14:18:45 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36520


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51600|review?                     |review+
               Flag|                            |




--- Comment #6 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-03-25 14:18:44 PST ---
(From update of attachment 51600)
I am ok with checking this in as-is as long as we all understand this is far
from final and is going in because we want to have something running to hack
on. Please spread FIXMEs liberally and start filing bugs, so that we don't
forget. Nate and I did this for V8 bindings refactoring, and it worked out
really well
(https://bugs.webkit.org/showdependencytree.cgi?id=32630&hide_resolved=0).

We will need to get rid of direct base dependencies, and convert all
std::string uses to WebString, and remove STL use.

On GURL::Resolve, we may have to poke this method through WebURL wrapper.

> +    if (!m_queue.isEmpty()) {
> +        // We delay processing queued work to avoid recursion problems.
> +        m_timer.Start(base::TimeDelta(), this, &WorkQueue::processWork);

How did base/time squeak by here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list