[Webkit-unassigned] [Bug 36520] [DRT/Chromium] Add LayoutTestController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36520





--- Comment #5 from TAMURA, Kent <tkent at chromium.org>  2010-03-24 23:58:38 PST ---
> > +#include "base/basictypes.h"
> > +#include "base/debug_util.h"
> > +#include "base/file_path.h"
> > +#include "base/message_loop.h"
> > +#include "base/path_service.h"
> > +#include "base/string_util.h"
> 
> Ouch, that's a lot of base dependencies. We should work to eliminate them.
> With these upstream, changing base code will be very difficult -- think of all
> the three-sided patches it will take.
> Let's convert them to WebKit API uses or build up webkit_support library.

ok, I'm adding some wrapper functions to webkit_support (See
http://codereview.chromium.org/1331001/show ), and remov almost all of them.

string_util.h remains.  I'll address it later.

> > +    : ALLOW_THIS_IN_INITIALIZER_LIST(m_timeoutFactory(this))
> > +    , m_shell(shell)
> > +    , ALLOW_THIS_IN_INITIALIZER_LIST(m_workQueue(this))
> 
> We can just drop ALLOW_THIS_IN_INITIALIZER_LIST in WebKit.

Done.

> > +    if (arguments.size() > 0 && arguments[0].isString()) {
> > +        GURL currentURL = m_shell->webView()->mainFrame()->url();
> > +        GURL fullURL = currentURL.Resolve(arguments[0].toString());
> 
> WebURL?

We need GURL because WebURL doesn't have Resolve().

> > +        m_userStyleSheetLocation = GURL(TestShell::rewriteLocalUrl(arguments[0].toString()));
> 
> Ditto.

We need GURL because WebURL doesn't have a constructor with a string.

> > +        m_shell->webView()->settings()->setUserStyleSheetLocation(m_userStyleSheetLocation);
> > +    GURL location(TestShell::rewriteLocalUrl(url));
> 
> Ditto.

Ditto.

> > +    } else {
> > +        result->set(false);
> > +    }
> 
> No braces here?

Done.

> > +    } else {
> > +        result->set(false);
> > +    }
> 
> Ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.