[Webkit-unassigned] [Bug 36495] Fix compilation on Solaris: mmap and munmap take char*

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36495





--- Comment #6 from Kent Hansen <kent.hansen at nokia.com>  2010-03-24 00:44:34 PST ---
(In reply to comment #5)
> (From update of attachment 51431 [details])
> Can we instead take care of this by setting up a header to overload these
> functions for void* on Solaris systems? I'd prefer a fix that doesn't require
> sprinkling the non-standard code around.

Hi Darin,
Yep, makes total sense; that should also remove the chance of this issue being
brought back to life again by newly introduced calls to mmap/munmap, which is
_really_ the problem to solve.

> If we put that in file called <wtf/MManExtras.h> and included that instead of
> <sys/mman.h> that would fit our normal portability approach.

Thanks for the suggestion, I'll try that one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.