[Webkit-unassigned] [Bug 36495] Fix compilation on Solaris: mmap and munmap take char*

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36495


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51431|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-03-23 10:35:36 PST ---
(From update of attachment 51431)
Can we instead take care of this by setting up a header to overload these
functions for void* on Solaris systems? I'd prefer a fix that doesn't require
sprinkling the non-standard code around.

Something like this:

    #if OS(SOLARIS)
    static inline void* mmap(void* addr, size_t length, int protections, int
flags, int fileDescriptor, off_t offset)
    {
        return mmap(static_cast<char*>(addr), length, protections, flags,
fileDescriptor, offset);
    }
    #endif

If we put that in file called <wtf/MManExtras.h> and included that instead of
<sys/mman.h> that would fit our normal portability approach.

review- because I'd like you to consider that option

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.