[Webkit-unassigned] [Bug 34924] Add checks if setNeedsWillValidateCheck() and setNeedsValidityCheck() are called correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 04:04:41 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=34924





--- Comment #4 from TAMURA, Kent <tkent at chromium.org>  2010-03-23 04:04:41 PST ---
Thank you for reviewing.

(In reply to comment #3)
> + setNeedsValidityCheck();
> 
> can be lifted above the "inputType() == FILE" if-clause because its called on
> both branches.

setNeedsValidityCehck() should be called
  after updating the value && before style recalc.
So this code is the best.

I'm adding a comment about it, and landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list