[Webkit-unassigned] [Bug 34924] Add checks if setNeedsWillValidateCheck() and setNeedsValidityCheck() are called correctly

Mon Mar 22 08:17:54 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=34924

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48721|review?                     |review+
               Flag|                            |

--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-03-22 08:17:54 PST ---
(From update of attachment 48721)
in HTMLInputElement::setValue, it looks like

+ setNeedsValidityCheck();

can be lifted above the "inputType() == FILE" if-clause because its called on
both branches.

This looks reasonable.  I'm not an expert on validity checks, but this patch
has been sitting around for a month and seems to prove the codebase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.