[Webkit-unassigned] [Bug 34888] Mac OS X: Use deployment target to determine whether memory tagging should be enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34888


Kent Hansen <kent.hansen at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50201|0                           |1
        is obsolete|                            |
  Attachment #51158|                            |review?, commit-queue?
               Flag|                            |




--- Comment #13 from Kent Hansen <kent.hansen at nokia.com>  2010-03-19 09:10:02 PST ---
Created an attachment (id=51158)
 --> (https://bugs.webkit.org/attachment.cgi?id=51158)
Revised patch (don't crash on Leopard when targeting Tiger!)

New attempt, this time tested on Tiger/Safari build, Leopard+SnowLeopard/Qt
build.

Executive summary:
- vm_{map,allocate} on (Snow) Leopard objects to being passed tag == -1.
- mmap on Tiger objects to being passed tag != -1.
- vm_{map,allocate} on Tiger doesn't mind being passed tag != -1.
- mmap on (Snow) Leopard doesn't mind being passed tag == -1.

The patch follows from that.
It would be nice if Geoffrey Garen (and/or Mark Rowe) could take a look at
this, since he did the original vm-tags Tiger crash fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.