[Webkit-unassigned] [Bug 34888] Mac OS X: Use deployment target to determine whether memory tagging should be enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 08:58:11 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=34888





--- Comment #12 from Kent Hansen <kent.hansen at nokia.com>  2010-03-16 08:58:10 PST ---
My comment copied from https://bugs.webkit.org/show_bug.cgi?id=36118#c11:

It looks like we are targeting Tiger (i.e. TARGETING_TIGER will be defined)
even when building on Leopard and above. This means it's going to use the
vm_map tags that work with Tiger, but unfortunately they _don't_ work with
Leopard (and vice versa). But not crashing on Leopard (and crashing on Tiger)
when you built it on Leopard is better than it not crashing on Tiger, I guess.
;D

The way it is now (or with the patch rolled out, that is), I think there should
be a configure/compile-time failure when this is detected, since we claim to
target Tiger but the binary is going to crash on Tiger. Or, we bump the default
macosx-version-min-required to 10.5 so that it will work for us (but one can
still override it one needs to target 10.4, which some of our customers still
do).

I'll also investigate whether there is a set of tags that work on both 10.4 and
10.5, even if that means disabling the features that the tagging provides
(AFAIK it's only for debugging/profiling?).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list