[Webkit-unassigned] [Bug 36259] <input type=range> does not validate correctly without a renderer and the tests are incorrect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36259





--- Comment #20 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-03-18 19:03:46 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > I recommend you post one patch per one bug.  Our commit-queue doesn't work well
> > with multiple patches in one bug, and having review comments for multiple
> > patches in one bug is confusing.
> 
> Fixing the other bug is a side-affect of this patch. They aren't technically
> the same bug, but they are both both solved at the same time. Moving the code
> from RenderSlider to HTMLInputElement meant no-longer calling
> HTMLInputElement::setValueFromRenderer, which was what the other bug was about.
> This bug was about the fact that no validation happened unless the range input
> had a renderer.
> 
> Does this make sense? Is there a way I could rewrite the ChangeLog to better
> handle this?

Prefix one ChangeLog with "Part 1 of 2:" and the other with "Part 2 of 2:".

I don't see why you need another bug for a series of two patches in this
particular case.  It's easier to review the patches separately anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.