[Webkit-unassigned] [Bug 36292] The numbers are not displayed properly when entering through VKB in number mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36292





--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2010-03-18 08:46:14 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > * A comment indicating that this is a missing feature in QGraphicsItem, ideally
> > with a link to an entry in the Qt JIRA tracking this missing feature. Then we
> > can remove this code again once it's fixed in Qt.
> 
> So what you are talking about is basically to have
> QGraphicsItem::updateMicroFocus()? I guess that makes sense, although it can't
> be a slot, because QGraphicsItem is not a QObject, so we would still need the
> extra slot in QGraphicsWebView.

Right. It could be turned into a slot in QGraphicsObject, btw. Then we could
also use it. But either way I think this should be filed in the Qt bug tracker
and we should reference it here.

> QGraphicsTextItem currently also solves this by calling ic->update(), although
> it looks at qApp->focusWidget() only, which might be smarter.

That's a good argument in favour of fixing it really in QGraphicsItem :-)

> > > +    for (int c = 0; c < views.size(); ++c) {
> > > +        QInputContext *ic = views[c]->inputContext();
> > 
> > I think you may want to use views.at(c) instead of [], to avoid detaching the
> > QList that the scene returns.
> 
> I don't think it detaches as long as the called function is also const, but in
> the sake of clarity, you're right. :-)

The variable is local, so why would the compiler choose the non-const []
overload? The constness of the currect function doesn't change that.

> > > +        if (ic)
> > > +            ic->update();
> > 
> > Shouldn't this be a call to views.at(c)->updateMicroFocus() instead?
> 
> Would be nice, but updateMicroFocus() is protected.

Dang! :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.