[Webkit-unassigned] [Bug 36292] The numbers are not displayed properly when entering through VKB in number mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36292





--- Comment #3 from Kristian Amlie <kristian.amlie at nokia.com>  2010-03-18 08:14:38 PST ---
(In reply to comment #2)
> * A comment indicating that this is a missing feature in QGraphicsItem, ideally
> with a link to an entry in the Qt JIRA tracking this missing feature. Then we
> can remove this code again once it's fixed in Qt.

So what you are talking about is basically to have
QGraphicsItem::updateMicroFocus()? I guess that makes sense, although it can't
be a slot, because QGraphicsItem is not a QObject, so we would still need the
extra slot in QGraphicsWebView.

QGraphicsTextItem currently also solves this by calling ic->update(), although
it looks at qApp->focusWidget() only, which might be smarter.

> > +    for (int c = 0; c < views.size(); ++c) {
> > +        QInputContext *ic = views[c]->inputContext();
> 
> I think you may want to use views.at(c) instead of [], to avoid detaching the
> QList that the scene returns.

I don't think it detaches as long as the called function is also const, but in
the sake of clarity, you're right. :-)

> > +        if (ic)
> > +            ic->update();
> 
> Shouldn't this be a call to views.at(c)->updateMicroFocus() instead?

Would be nice, but updateMicroFocus() is protected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.