[Webkit-unassigned] [Bug 35446] Add support for Widgets 1.0: View Mode Media Feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35446





--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-16 12:58:12 PST ---
Thanks for the comments

> 1) It introduces a build guard (which I think it ok) w/ the name
> "ENABLE_WEBWIDGET_SUPPORT", however the spec says "Widgets" (note the S in the
> end). Maybe it could be changed accordingly.

I guess we could use ENABLE_WIDGETS_10_SUPPORT. I was afraid that people would
confuse it with something else. That is why I added the WEB as well.

> 2) Patch adds the term "WEBWIDGET", although the specs say "Widget" (w/o
> "Web"). What do you think?

I'm OK with ENABLE_WIDGETS_10_SUPPORT / ENABLE(WIDGETS_10_SUPPORT)

> 
> 3) Do we really need the -webkit prefix as in "-webkit-view-mode: mode" syntax.
> Is that because the spec is still a draft?

We don't. I actually believe it is wrong. -webkit is used for CSS properties as
they are ignored by other browser. This is not how it works for media features,
as if the browser doesn't know a media feature it defaults to false.

I suggest just using view-mode and not -webkit-view-mode.

> 4) Patch introduces 4 possible values (mini, float, application and
> fullscreen). I just checked the implementation, and there is an additional
> "all" value, which means:

Yes, this was added in the latest spec, and it will need some special
treatment.

> 5) If the above is corrent, patch should also reset DRT to "all" after each
> test execution.

No, because that means that you are running as a Widget, and it will always
return true. It should only return true for "all" when we are in one of the 4
other modes. For non Widget 1.0 views, it should return false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.