[Webkit-unassigned] [Bug 35446] Add support for Widgets 1.0: View Mode Media Feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35446





--- Comment #3 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2010-03-16 12:45:06 PST ---
(In reply to comment #0)
> Created an attachment (id=49617)
 --> (https://bugs.webkit.org/attachment.cgi?id=49617) [details]
> Patch
> 
> The patch adds support for the view mode feature:
> http://www.w3.org/TR/widgets-vmmf/
> 
> It is currently only enabled for the Qt port.

I was walking through the patch, and a few questions raised:

1) It introduces a build guard (which I think it ok) w/ the name
"ENABLE_WEBWIDGET_SUPPORT", however the spec says "Widgets" (note the S in the
end). Maybe it could be changed accordingly.

2) Patch adds the term "WEBWIDGET", although the specs say "Widget" (w/o
"Web"). What do you think?

3) Do we really need the -webkit prefix as in "-webkit-view-mode: mode" syntax.
Is that because the spec is still a draft?

4) Patch introduces 4 possible values (mini, float, application and
fullscreen). I just checked the implementation, and there is an additional
"all" value, which means:

"The all value is defined to describe a widget for which it is irrelevant how
it is displayed. The presentation of the widget is fully dependant on the user
agent. This value does not define any actual presentation mode of a widget.

This value is to be used to override the default presentation mode set to
floating that would be applied if no value is specified in the document.
"

, which btw I think should be the default value, if none is set by the webpage.

5) If the above is corrent, patch should also reset DRT to "all" after each
test execution.

Kenneth, what do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.