[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33413





--- Comment #17 from Enrica Casucci <enrica at apple.com>  2010-03-11 16:49:21 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > > +            if ((caretOffset == caretMaxOffset) ^ (affinity == DOWNSTREAM))
> > > +                break;
> > > +
> > 
> > Why this? affinity is only UPSTREAM or DOWNSTREAM.
> > You could change the code to be
> >              if (caretOffset == caretMinOffset)
> >                   break;
> > and have only one if statement instead of 2.
> 
> I think maybe you misread? The comparison above is to caretMaxOffset, not
> caretMinOffset.
> 
> > 
> > >              if ((caretOffset == caretMinOffset) ^ (affinity == UPSTREAM))
> > >                  break;

My mistake, sorry. I would still prefer to see only one if with an or rather
than 2 if statements with a break. Not a big deal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.