[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 10:33:23 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33413





--- Comment #16 from Ojan Vafai <ojan at chromium.org>  2010-03-11 10:33:22 PST ---
(In reply to comment #15)
> > +            if ((caretOffset == caretMaxOffset) ^ (affinity == DOWNSTREAM))
> > +                break;
> > +
> 
> Why this? affinity is only UPSTREAM or DOWNSTREAM.
> You could change the code to be
>              if (caretOffset == caretMinOffset)
>                   break;
> and have only one if statement instead of 2.

I think maybe you misread? The comparison above is to caretMaxOffset, not
caretMinOffset.

> 
> >              if ((caretOffset == caretMinOffset) ^ (affinity == UPSTREAM))
> >                  break;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list