[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 10 20:40:48 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33413
--- Comment #10 from Ojan Vafai <ojan at chromium.org> 2010-03-10 20:40:47 PST ---
(From update of attachment 50465)
> +++ b/WebCore/ChangeLog
> + Selection.modify() with 'lineboundary' guranuality implies just
> + "Go to the end of the line", unlike selection expansioin with
Typo: s/expansioin/expansion
> +++ b/WebCore/editing/SelectionController.cpp
> + // LineBoundary granularity actually emulates
> + // NSTextView#moveToRightEndOfLineAndModifySelection(),
> + // which never expands selection across multiple lines.
> + // So we set UPSTREAM affinity to prevent to crossing
> + // line when the offset is at the end of line.
Grammar fix:
> + // which never expands a selection across multiple lines.
> + // So we set UPSTREAM affinity to prevent crossing the
> + // line boundary when the offset is at the end of the line.
Otherwise look good to me. I'm not a reviewer though. :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list