[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33413


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |morrita at google.com




--- Comment #9 from MORITA Hajime <morrita at google.com>  2010-03-10 20:22:26 PST ---
Thank you for the review and further experiments! > ojan, ap
I update patch to cleanup changelog/comment mess.
Would you give the review for updated one?

>2) I don't understand why this says "mimic". Don't we just plain use it? And
>would anything break if you didn't add
>"pos.setAffinity(m_selection.affinity());"?
I agree that isn't a mimicking stuff.

At first I thought I should keep affinity as before modify() 
and swapping affinity temporally looks like "mimic" for me.
But all tests passed without that line so I removed it,
and now it looks natural for me. 

>Also, I tested the modifyMovingForward case (cmd+left and cmd+right). They work
>in the testcase.
Yes. modify('move', ... ) already works as expected.
It seems 'move' has its own logic other than 'extend' for line-boundary
behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.