[Webkit-unassigned] [Bug 35844] [Qt] Add support for LayoutTestController commands.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35844





--- Comment #6 from Robert Hogan <robert at webkit.org>  2010-03-10 12:33:27 PST ---
> 
> The point is. You will be adding ~10-15 public API methods (setters and
> getters) that have little usage outside of the DRT. This raises my concern that
> this might be the wrong approach.

Think we're talking at cross-purposes here. This is the isCommandEnabled API
the patch adds to the DRT:

+bool LayoutTestController::isCommandEnabled(const QString& name) const
+{
+    return qt_drt_isCommandEnabled(m_drt->webPage(), name);
+}
+

+bool QWEBKIT_EXPORT qt_drt_isCommandEnabled(QWebPage* page, const QString&
name)
+{
+    return
page->handle()->page->focusController()->focusedOrMainFrame()->editor()->command(name).isEnabled();
+}
+

No need to add any enums surely? (Apologies if I'm completely missing your
point).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.