[Webkit-unassigned] [Bug 35844] [Qt] Add support for LayoutTestController commands.

Wed Mar 10 13:48:25 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=35844

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50171|review?                     |review-
               Flag|                            |

--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2010-03-10 13:48:25 PST ---
(From update of attachment 50171)
Looks good in general, yay for passing more tests.

The part I'm unhappy about are the functions added to QWebPage:

* We usually don't have toggle() functions for plain boolean properties.
* The added properties are lacking documentation!
* I'd like to see the names discussed/proposed on the mailing list first, for a
wider review.
* The selectTrailingWhitespaceEnabled property is lacking a Q_PROPERTY
declaration

An alternative to the public API would and a cleanup of all the _drt_ functions
would be to collect all those ugly qt_drt_foo functions, put them into
WebCoreSupport/DumpRenderTreeSupport.cpp/h, _export_ the entire class and
access it from the DRT by including the private header file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.