[Webkit-unassigned] [Bug 35811] [chromium] need DragImage implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35811





--- Comment #17 from Evan Stade <estade at chromium.org>  2010-03-10 08:55:51 PST ---
(In reply to comment #16)
> (From update of attachment 50269 [details])
> > Index: WebKit/chromium/public/WebViewClient.h
> ...
> >      virtual void startDragging(
> > -        const WebPoint& from, const WebDragData&, WebDragOperationsMask) { }
> > +        const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }
> 
> Can you avoid making this a two-sided patch landing by continuing
> to support the old API temporarily?

we can land the chrome side first now without anything breaking. Sorry, I
should have mentioned that here. I only mentioned that at
http://codereview.chromium.org/668125/show. So perhaps it would be best to
review that side of it first?

> 
> 
> > Index: WebKit/chromium/src/DragClientImpl.cpp
> ...
> > +#if WEBKIT_USING_SKIA
> > +    m_webView->startDragging(
> > +        dragData, static_cast<WebDragOperationsMask>(dragOperationMask),
> > +        WebImage(*dragImage), offsetPoint);
> > +#else
> > +    // FIXME
> 
> ^^^ Can you add a comment about this FIXME?  Something about needing
> to pass a non-empty image perhaps?

ok

> 
> 
> Are the style bot issues something to worry about?

yes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.