[Webkit-unassigned] [Bug 35811] [chromium] need DragImage implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35811


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50269|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #16 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-09 22:36:43 PST ---
(From update of attachment 50269)
> Index: WebKit/chromium/public/WebViewClient.h
...
>      virtual void startDragging(
> -        const WebPoint& from, const WebDragData&, WebDragOperationsMask) { }
> +        const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }

Can you avoid making this a two-sided patch landing by continuing
to support the old API temporarily?


> Index: WebKit/chromium/src/DragClientImpl.cpp
...
> +#if WEBKIT_USING_SKIA
> +    m_webView->startDragging(
> +        dragData, static_cast<WebDragOperationsMask>(dragOperationMask),
> +        WebImage(*dragImage), offsetPoint);
> +#else
> +    // FIXME

^^^ Can you add a comment about this FIXME?  Something about needing
to pass a non-empty image perhaps?


Are the style bot issues something to worry about?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.