[Webkit-unassigned] [Bug 35874] [Chromium] Adding touch event routing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35874





--- Comment #3 from Garret Kelly (Google) <gdk at chromium.org>  2010-03-08 14:32:16 PST ---
(In reply to comment #2)
> (From update of attachment 50240 [details])
> > +++ b/WebKit/chromium/src/ChromeClientImpl.h
> ...
> > +#if ENABLE(TOUCH_EVENTS)
> > +    virtual void needTouchEvents(bool needTouchEvents) { }
> > +#endif
> 
> ^^^ is there more to be done here?  should there be a FIXME comment?

Quite right. FIXME added.

> > +++ b/WebKit/chromium/src/WebViewImpl.cpp
> > @@ -609,6 +609,22 @@ bool WebViewImpl::charEvent(const WebKeyboardEvent& event)
> >      return true;
> >  }
> >  
> > +#if ENABLE(TOUCH_EVENTS)
> > +bool WebViewImpl::touchEvent(const WebTouchEvent& event)
> > +{
> > +    Frame* focusedFrame = focusedWebCoreFrame();
> > +    if (!focusedFrame)
> > +        return false;
> > +
> > +    EventHandler* eventHandler = focusedFrame->eventHandler();
> > +    if (!eventHandler)
> > +        return false;
> > +
> > +    PlatformTouchEventBuilder touchEventBuilder(mainFrameImpl()->frameView(), event);
> > +    return eventHandler->handleTouchEvent(touchEventBuilder);
> > +}
> 
> Are you sure that calling handleTouchEvent on the focused frame is correct?
> For mouseDown, etc., we use the EventHandler of the main frame.
> 
> It looks like an EventHandler for a subframe will still perform a hit test
> on the topmost frame if the subframe does not contain the point, so it may
> not matter what EventHandler you use.  I was just wondering why you chose
> the EventHandler of the focused frame.

Your right, the hit test shouldn't start in the focused frame but in the
topmost. Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.