[Webkit-unassigned] [Bug 35727] [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35727


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50195|review?                     |review-
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-03-08 13:56:02 PST ---
(From update of attachment 50195)
 24 #if GTK_CHECK_VERSION(2, 18, 0)
 25 #define WIDGET_HAS_WINDOW(widget) gtk_widget_get_has_window(widget)
 26 #else
 27 #define WIDGET_HAS_WINDOW(widget) !GTK_WIDGET_NO_WINDOW(widget)

I think creating a utils file just for this is not worth it. Why not add a
function to the WidgetGtk class (or file), as Eric suggested?

 691 #if GTK_CHECK_VERSION(2, 18, 0)
 692     if (gtk_widget_is_sensitive(widget)) {
 693 #else
691694     if (GTK_WIDGET_IS_SENSITIVE(widget)) {
 695 #endif

This is unrelated. Please put it into another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.