[Webkit-unassigned] [Bug 35727] [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 9 00:21:05 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35727
--- Comment #6 from Philippe Normand <pnormand at igalia.com> 2010-03-09 00:21:05 PST ---
(In reply to comment #5)
> (From update of attachment 50195 [details])
> 24 #if GTK_CHECK_VERSION(2, 18, 0)
> 25 #define WIDGET_HAS_WINDOW(widget) gtk_widget_get_has_window(widget)
> 26 #else
> 27 #define WIDGET_HAS_WINDOW(widget) !GTK_WIDGET_NO_WINDOW(widget)
>
> I think creating a utils file just for this is not worth it. Why not add a
> function to the WidgetGtk class (or file), as Eric suggested?
>
Ok can you tell me what you want exactly? a method of the class or a static
function?
> 691 #if GTK_CHECK_VERSION(2, 18, 0)
> 692 if (gtk_widget_is_sensitive(widget)) {
> 693 #else
> 691694 if (GTK_WIDGET_IS_SENSITIVE(widget)) {
> 695 #endif
>
> This is unrelated. Please put it into another patch.
I just put it in this patch because it was fixing my build for the same reasons
(gtk deprecating apis)... but yeah fine, it just adds one patch in the queue :P
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list