[Webkit-unassigned] [Bug 35841] WebSystemInterface.m should not explicitly include <wtf/Platform.h>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35841





--- Comment #2 from Mark Rowe (bdash) <mrowe at apple.com>  2010-03-07 11:25:02 PST ---
(In reply to comment #1)
> Thanks for filing this.  Given the IRC discussion last time (whose confusion I
> think you accurately characterize; everybody involved thought PCH rather than
> prefix header), it would be nice to publicly state whatever the policy is going
> forward, once people agree.  Hopefully that'll reduce future confusion.

It seems to me that the policy for WebKit/mac is already perfectly clear: the
compilers used by the Mac build all support prefix headers, so we always use a
prefix header rather than explicitly including a header like “config.h”.  I see
this as something people need to agree on.  It’s how things work.

> (Note: Most of r55633 seems OK either way, since it notes that most of the
> modified headers pull in Platform.h via config.h, and that's obviously
> redundant and fine to fix regardless of the resolution on this bug.)

I don’t know what you’re saying here.  All of r55633 was ok.  It removed
includes that are unnecessary either because config.h included them, or because
the code in question is always built with a prefix header that includes them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.