[Webkit-unassigned] [Bug 35841] WebSystemInterface.m should not explicitly include <wtf/Platform.h>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35841


Peter Kasting <pkasting at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|pkasting at google.com         |mjs at apple.com




--- Comment #1 from Peter Kasting <pkasting at google.com>  2010-03-06 22:21:20 PST ---
Thanks for filing this.  Given the IRC discussion last time (whose confusion I
think you accurately characterize; everybody involved thought PCH rather than
prefix header), it would be nice to publicly state whatever the policy is going
forward, once people agree.  Hopefully that'll reduce future confusion.

FWIW, I think a world where files are explicit about all headers they need is
better than a world in which you need a prefix header to make things compile. 
OTOH, I don't have much to do with the Mac builds of Safari _or_ Chromium, so
my opinion doesn't really matter.  I was only involved last time insofar as
trying to find knowledgeable people on both sides to decide what the fix should
be.

(Note: Most of r55633 seems OK either way, since it notes that most of the
modified headers pull in Platform.h via config.h, and that's obviously
redundant and fine to fix regardless of the resolution on this bug.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.