[Webkit-unassigned] [Bug 35841] New: WebSystemInterface.m should not explicitly include <wtf/Platform.h>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35841

           Summary: WebSystemInterface.m should not explicitly include
                    <wtf/Platform.h>
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mrowe at apple.com
                CC: eric at webkit.org, sam at webkit.org, pkasting at google.com,
                    abarth at webkit.org


The Mac build of the WebKit framework specifies a prefix header that includes
<wtf/Platform.h> so there’s no reason for individual files within the project
to do so.  This was added in r52356 in a change labeled as a build fix.  From
what I can gather from the commit message and related bug (bug 32753) this
appears to have been added out of some confusion between the concept of a
prefix header and a precompiled header.  The ChangeLog talks about precompiled
header files and distcc.  There’s no requirement that WebKit’s prefix header be
precompiled and therefore, as far as I can tell, no reason why this file is
being explicitly included rather than using the prefix header like every other
compilation unit in the Mac WebKit build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.