[Webkit-unassigned] [Bug 38256] [GTK] Random failure on 'testdownload' unit test

Tue Jun 29 04:59:51 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38256

Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55972|0                           |1
        is obsolete|                            |
  Attachment #60009|                            |review?
               Flag|                            |

--- Comment #18 from Mario Sanchez Prada <msanchez at igalia.com>  2010-06-29 04:59:51 PST ---
Created an attachment (id=60009)
 --> (https://bugs.webkit.org/attachment.cgi?id=60009)
Make sure the set_filename function is called after handling the 'download-requested' signal for the asynchronous test

(In reply to comment #17)
> [...]
> As commented, it would be nice to add here the explanation in comment #15, since you already wrote it.

Done, sorry.

> >+            g_idle_add((GSourceFunc)set_filename, g_strdup(temporaryFilename));
> 
> Mmm, do you really need to dup the string?

As the string is gonna be used in a function called "on idle", I'd rather do it this way and then free the string there. I think it's safer.

> [...]
> >+    GCallback dr_cb = NULL;
> 
> downloadRequestCallback? or downloadRequestCB? or something not 'dr_cb' :D

Sure! Done.

Attached new patch addressing these issues

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.