[Webkit-unassigned] [Bug 38256] [GTK] Random failure on 'testdownload' unit test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38256


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55972|review?                     |review-
               Flag|                            |




--- Comment #17 from Xan Lopez <xan.lopez at gmail.com>  2010-06-29 04:45:50 PST ---
(From update of attachment 55972)
>--- a/WebKit/gtk/ChangeLog
>+++ b/WebKit/gtk/ChangeLog
>@@ -1,3 +1,21 @@
>+2010-05-06  Mario Sanchez Prada  <msanchez at igalia.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GTK] Random failure on 'testdownload' unit test
>+        https://bugs.webkit.org/show_bug.cgi?id=38256
>+
>+        Make sure the set_filename function is called after
>+        handling the 'download-requested' signal for the
>+        asynchronous test.
>+
>+        * tests/testdownload.c:
>+        (set_filename):
>+        (handle_download_requested_cb):
>+        (download_requested_cb):
>+        (download_requested_asynch_cb):
>+        (test_webkit_download_perform):
>+

As commented, it would be nice to add here the explanation in comment #15, since you already wrote it.

>+            g_idle_add((GSourceFunc)set_filename, g_strdup(temporaryFilename));

Mmm, do you really need to dup the string?

>+        } else {
>+            gchar *uri = g_filename_to_uri(temporaryFilename, NULL, NULL);
>+            if (uri)
>+                webkit_download_set_destination_uri(download, uri);
>+            g_free(uri);
>+        }
>     }
> 

>+    GCallback dr_cb = NULL;

downloadRequestCallback? or downloadRequestCB? or something not 'dr_cb' :D

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.