[Webkit-unassigned] [Bug 41228] Fix http/tests/local/blob/send-data-blob.html on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41228


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59943|review?                     |review-
               Flag|                            |




--- Comment #5 from Jian Li <jianli at chromium.org>  2010-06-28 16:15:57 PST ---
(From update of attachment 59943)
WebCore/platform/BlobItem.cpp:128
 +  // Convert line-endings (CR and LF) into CRLF.
Probably better to say:
  // Normalize all line-endings to CRLF.

WebCore/platform/BlobItem.cpp:176
 +  static CString convertToCR(const CString& from)
I think we can combine convertToCR and convertToLF to one single function like the following:
  convertToCROrLF(const CString& from, bool toCR)
  {
      char fromLineEndingChar = toCR ? '\n' : '\r';
      char toLineEndingChar = toCR ? '\r' : '\n';
      ...
      while (...) {
          ...
          } else if (c == fromLineEndingChar) {
              // Turn CF/LF into LF/CR.
  }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.