[Webkit-unassigned] [Bug 41228] Fix http/tests/local/blob/send-data-blob.html on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41228





--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-28 14:48:19 PST ---
I rewrote the convertToCString function with single-purpose three functions that just convert line-endings into CRLF, CR and LF respectively.

(In reply to comment #2)
> (From update of attachment 59801 [details])
> LayoutTests/ChangeLog:7
>  +          Also fix test expectations for Windows.
> Please add an empty line before this line.

Done.

> WebCore/ChangeLog:7
>  +          Fix line-ending conversion code.  Seems like I made a bad fix.
> Please add an empty line before this line. Also might be better to say something like:
>   Fix a regression bug in line-ending conversion code.

Fixed.

> WebCore/platform/BlobItem.cpp:158
>  +                      ++needFix;
> It seems to better to define needFix as a boolean.

Done.

> WebCore/platform/BlobItem.cpp:185
>  +              } else if (ending != EndingCR) {
> What are you going to do with else part? Do we need to copy the '\r' character?

(In the previous code) yes, else case would be char=='\r' and ending==EndingCR.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.