[Webkit-unassigned] [Bug 40781] Web Inspector: show actual breakpoint position in UI.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40781





--- Comment #8 from Yury Semikhatsky <yurys at chromium.org>  2010-06-28 08:48:01 PST ---
(From update of attachment 59898)
WebCore/inspector/InspectorController.cpp:1752
 +      String breakpointId = String::format("%s:%d", sourceID.utf8().data(), actualLineNumber);
Extract this code in a function please.

WebCore/inspector/InspectorController.cpp:1780
 +      it->second.remove(stickyLine);
You may want to remove "it" from the map if it->second becomes empty.

WebCore/inspector/InspectorController.h:387
 +      HashMap<String, int> m_breakpointsMapping;
Shouldn't the value type be unsigned here?

WebCore/inspector/front-end/BreakpointManager.js:122
 +          var that = this;
Use .bind(this) instead, for consistency with the rest code.

WebCore/inspector/InspectorController.cpp:1772
 +      int stickyLine = m_breakpointsMapping.take(breakpointId);
This mapping is a bit confusing. One breakpoint may result is several breakpoints with same URL and different line numbers and deleting any of them will clear the original setting while leaving intact all other breakpoints restored from that setting in other scripts. Probably we should delete all the breakpoints in that case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.