[Webkit-unassigned] [Bug 40781] Web Inspector: show actual breakpoint position in UI.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40781





--- Comment #7 from Pavel Podivilov <podivilov at chromium.org>  2010-06-28 08:11:45 PST ---
(In reply to comment #5)
> (From update of attachment 59770 [details])
> WebCore/bindings/js/ScriptDebugServer.cpp:140
>  +  bool ScriptDebugServer::setBreakpoint(const String& sourceID, ScriptBreakpoint breakpoint, int lineNumber, int* actualLineNumber)
> Given that you still prefer returning bool, you don't need to encode -1, so you should use unsigned values for line numbers.

Done.

> WebCore/inspector/InspectorController.h:387
>  +      HashMap<String, int> m_breakpointsMapping;
> So why do you need this mapping after all? Why does sourceID:line not identify breakpoint properly?

This mapping is needed to preserve existing behavior. If breakpoint was restored to several scripts in didParseSource, and user removes that breakpoint from one of the scripts, we want it to be removed from settings. And since line numbers do not necessarily match now, we need such a mapping.

> 
> Btw, if you really need unique breakpoint ids, now that setBreakpoint has a callback, you could assign them on backend (using progress counter) and send them back to the backend.

Let me introduce it in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.