[Webkit-unassigned] [Bug 40222] Use the new SoupURILoader API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 28 02:04:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40222





--- Comment #8 from Sergio Villar Senin <svillar at igalia.com>  2010-06-28 02:04:25 PST ---
(In reply to comment #7)
> (From update of attachment 59635 [details])
> WebCore/platform/network/soup/ResourceHandleSoup.cpp:547
>  +          client->didFinishLoading(handle.get());
> You are missing checks here for the existance of the client and for cancelling. The didReceiveData above may have cancelled it, we'll get crashes.

True

> 
> WebCore/platform/network/soup/ResourceHandleSoup.cpp:490
>  +          gulong gotChunkHandler = GPOINTER_TO_UINT(userData);
> Eeww. I don't think this is right. This will do a cast to guint. I would prefer removing this hack, and using a variable inside the ResourceHandleInternal hack instead.

Ok

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:566
>  +      // returns a stream whose outcome is a HTML with a list of files
> "whose content is HTML", I think, sounds better; I don't see any special handling for directories, though, should there be? It appears the special handling is for any file: URIs

Thing is that for directories we'll get a SoupDirectoryInputStream instead of a GFileInputStream. If we get that soup stream we'll handle it as a normal stream with HTML content. Maybe we could set the condition as !SOUP_IS_DIRECTORY_INPUT_STREAM

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list