[Webkit-unassigned] [Bug 40222] Use the new SoupURILoader API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40222


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59635|review?                     |review-
               Flag|                            |




--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2010-06-25 05:57:15 PST ---
(From update of attachment 59635)
WebCore/platform/network/soup/ResourceHandleSoup.cpp:547
 +          client->didFinishLoading(handle.get());
You are missing checks here for the existance of the client and for cancelling. The didReceiveData above may have cancelled it, we'll get crashes.


WebCore/platform/network/soup/ResourceHandleSoup.cpp:490
 +          gulong gotChunkHandler = GPOINTER_TO_UINT(userData);
Eeww. I don't think this is right. This will do a cast to guint. I would prefer removing this hack, and using a variable inside the ResourceHandleInternal hack instead.

WebCore/platform/network/soup/ResourceHandleSoup.cpp:566
 +      // returns a stream whose outcome is a HTML with a list of files
"whose content is HTML", I think, sounds better; I don't see any special handling for directories, though, should there be? It appears the special handling is for any file: URIs

r- for the reasons above, I'll try to get this installed and start running with it to get it tested =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.