[Webkit-unassigned] [Bug 41153] rebaseline-chromium-webkit-tests should add or remove files to local git repository

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 27 21:18:45 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41153





--- Comment #19 from Eric Seidel <eric at webkit.org>  2010-06-27 21:18:44 PST ---
(From update of attachment 59869)
WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:910
 +                               help='Supress result HTML viewing')
Typo "Suppress" (at least in american english).

WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:909
 +                               default=False,
Generally I don't bother to list default=False, since default=None automatically and I intentionally avoid treating None different from False in my checks (although I don't know if there is consensus in that approach).

WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:923
 +                               default=(''),
Leaving this out, so that it's None seems better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list