[Webkit-unassigned] [Bug 41153] rebaseline-chromium-webkit-tests should add or remove files to local git repository

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41153


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59869|review?                     |review+
               Flag|                            |




--- Comment #18 from Eric Seidel <eric at webkit.org>  2010-06-27 21:16:22 PST ---
(From update of attachment 59869)
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:528
 +          # path is assumed to be cwd relative?
This is a general problem with this class and part of why we recently add a "run" method which knows how to set the CWD to the webkit root when necessary.

WebKitTools/Scripts/webkitpy/common/checkout/scm.py:575
 +          return self.run_status_and_extract_filenames(self.status_command(), self._status_regexp("D"))
We should probably add a new abstraction for this soon.  self._files_matching_status("D") or similar.  Not needed for this patch.

WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:391
 +      def _shared_test_add_recursively(self):
Eventually I need to figure out a better way to do these "shared" tests.

WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:650
 +          self.scm.propset("svn:mime-type", "application/octet-stream", filepath)
The test would be slightly better if it used an impossible mimetype, so that we knew there was no way SVN would autodetect to that particular type.

WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:485
 +                      _log.warn('  Failed to add baselines to SVN.')
Not quite true anymore. :)

This is a FANTASTIC step forward.  Thank you for doing this!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.