[Webkit-unassigned] [Bug 27443] [Gtk] Combobox should support "find-as-you-type" search

[Apelete Seketeli]

On 16-Jun-10, bugzilla-daemon at webkit.org wrote:
> --- Comment #11 from Gustavo Noronha (kov) <gns at gnome.org>  2010-06-16 13:48:55 PST ---
> (From update of attachment 57170)
> WebCore/platform/PopupMenu.h:77
>  +  void trim(std::string&);
> We should protect all of the code with the platform checks. Having said that, I don't like having a trim implementation solely for this case. Aren't there other trim implementations in standard libraries we can use? I know pango has pango_trim_string, for example, could we not use it? In case there is no, I'd prefer having that code go into one of WebKit's string classes, and that class should be used here instead of std::string.

So it's okay to include pango in order to use pango_trim_string ? It
actually exists, but I wasn't aware of it before.

> WebCore/platform/gtk/PopupMenuGtk.cpp:266
>  +              searchDomain = GTK_MENU_SHELL(that->m_popup.get())->children;
> We are avoiding using struct fields directly. Please use the same method used here: http://trac.webkit.org/changeset/61206

Looked at the method you're talking about, but since the benefit of it
isn't clear to me is that the only occurrence I should correct ?

> Have you considered contributing something similar to GTK+ directly?

I actually thought that the feature was missing in GTK+ as first, but
then I was told to implement it directly inside WebKit. Is it okay for
me to continue working on the patch in order to get it approved in
WebKit ?

Regards.
-- 
        Apelete