[Webkit-unassigned] [Bug 27443] [Gtk] Combobox should support "find-as-you-type" search

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27443


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57170|review?                     |review-
               Flag|                            |




--- Comment #11 from Gustavo Noronha (kov) <gns at gnome.org>  2010-06-16 13:48:55 PST ---
(From update of attachment 57170)
WebCore/platform/gtk/PopupMenuGtk.cpp:31
 +  #include <algorithm>
Includes must be ordered, please take a look at http://webkit.org/coding/coding-style.html

WebCore/platform/PopupMenu.h:77
 +  void trim(std::string&);
We should protect all of the code with the platform checks. Having said that, I don't like having a trim implementation solely for this case. Aren't there other trim implementations in standard libraries we can use? I know pango has pango_trim_string, for example, could we not use it? In case there is no, I'd prefer having that code go into one of WebKit's string classes, and that class should be used here instead of std::string.

WebCore/platform/gtk/PopupMenuGtk.cpp:236
 +           ++i) {
This construct is very unusual in WebKit, please use a single line for code like this.

WebCore/platform/gtk/PopupMenuGtk.cpp:266
 +              searchDomain = GTK_MENU_SHELL(that->m_popup.get())->children;
We are avoiding using struct fields directly. Please use the same method used here: http://trac.webkit.org/changeset/61206

Have you considered contributing something similar to GTK+ directly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.