[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientation and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #11 from Steve Block <steveblock at google.com>  2010-06-25 08:09:33 PST ---
> Just a thought here: it might be desirable to do m_listeners.add(window) before
> calling m_client->startUpdating(). It could be that on
> DeviceOrientationClient::startUpdating(), it immediately calls back into
> DeviceOrientation::onDeviceOrientation() with e.g. the last known orientation,
> or values indicating that it can't deliver any orientation data, and then there
> wouldn't be any registered listeners yet.
Thanks for the comment Hans.  My intention was that the client must always call back asynchronously. I think that's the more usual pattern. However, you're right that I should either make this requirement explicit, or make sure that re-entrant calls to DeviceOrientation::onDeviceOrientation() from DeviceOrientationClient::startUpdating() are handled correctly.

Anybody care to review?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.