[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientation and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #10 from hans at chromium.org  2010-06-25 04:24:48 PST ---
> WebCore/dom/DeviceOrientation.cpp:42
> +void DeviceOrientation::addListener(DOMWindow* window)
> +{
> +    if (m_listeners.isEmpty() && m_client)
> +        m_client->startUpdating();
> +    m_listeners.add(window);
> +}
Just a thought here: it might be desirable to do m_listeners.add(window) before calling m_client->startUpdating(). It could be that on DeviceOrientationClient::startUpdating(), it immediately calls back into DeviceOrientation::onDeviceOrientation() with e.g. the last known orientation, or values indicating that it can't deliver any orientation data, and then there wouldn't be any registered listeners yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.