[Webkit-unassigned] [Bug 40986] Change to Vertical Alignment of MathML Constructs to Use the Baseline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40986





--- Comment #3 from Alex Milowski <alex at milowski.com>  2010-06-23 02:42:10 PST ---
(In reply to comment #1)
> (From update of attachment 59371 [details])
> LGTM.
> 
> 165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
>  166             if (heightDiff < 0) 
>  167                 heightDiff = 0;
> 
> maybe add a comment to when this can happen?

Only if the base is bigger than the scripts.   That shouldn't happen unless you are in the process of row height calculation.  I should add a comment to that effect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.