[Webkit-unassigned] [Bug 40986] Change to Vertical Alignment of MathML Constructs to Use the Baseline

Tue Jun 22 14:59:39 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40986

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59371|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-22 14:59:39 PST ---
(From update of attachment 59371)
LGTM.

165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
 166             if (heightDiff < 0) 
 167                 heightDiff = 0;

maybe add a comment to when this can happen?

WebCore/mathml/RenderMathMLUnderOver.cpp:255
 +              baseline += static_cast<int>((zoomFactor > 1.25 ? 2 : 3) * zoomFactor);
ieck :-) good that you added a FIXME at least.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.